DTPOMERSER-1275 - iOS UI SDK - Create Transfer Method: List default currency per selected country#385
Merged
akalichety-hw merged 10 commits intomasterfrom Feb 12, 2025
Conversation
select default currency code.
akalichety-hw
requested review from
fzhang4-hw,
grmeyer-hw-dev and
shubh-hw-dev
Used existing Locale for error message.
Collaborator
Author
|
UI Test Result: Failing tests:
|
Collaborator
Author
Collaborator
grmeyer-hw-dev
left a comment
grmeyer-hw-dev
left a comment
There was a problem hiding this comment.
Can you check this test AddTransferMethodPresenterTests.testLoadTransferMethodConfigurationFields_failure ? it's failing
grmeyer-hw-dev
changed the title
Used that method in already existing method to avoid if and else conditions.
fzhang4-hw
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket DTPOMERSER-1275
Changes
Tests
select_default_currency.mp4
Dependency